Code for generating error catalog from source code #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 20, 2023 12:41
added 2 commits
May 26, 2023 14:00
atomb
requested changes
May 26, 2023
| Note that a missing body is different than an empty body, which is just `{ }`. | ||
| However, the body must be supplied before the program can be compiled, | ||
| even if the method is `ghost`. | ||
| Body-less loops in ghost methods are similar to unchecked assumptions. |
There was a problem hiding this comment.
Here, "similar" may be more accurate.
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
atomb
previously approved these changes
May 26, 2023
added 2 commits
May 26, 2023 19:03
|
Yep - first time using the process, so you need to push the approve button again. -- Optimistically presuming the tests will succeed |
atomb
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.